[In Progress] Code Reviews

Before Sending CR

  1. Keep trivial changes like renaming, reformatting, moving code around in its own Pull Request (PR) ; Keep refactoring code in its own PR; Keep rest of the code in separate PR. Combining these three will dilute PR, people either won’t review by looking at sheer number of changes or will leave too many comments ending up in a myriad of ping pongs resulting in overall compromising tiresome experience.
  2. Keep smaller PRs, Keep them to one issue (or minimal logical conclusion of feature) ;
  3. Try to develop one or two buddies. This greatly improves turn around time of your PRs. Of course you need to reciprocate the same.

Leave a Reply

Your email address will not be published. Required fields are marked *

This site uses Akismet to reduce spam. Learn how your comment data is processed.